Skip to content
This repository has been archived by the owner on Nov 26, 2024. It is now read-only.

Fix/656/json #664

Closed
wants to merge 1 commit into from
Closed

Fix/656/json #664

wants to merge 1 commit into from

Conversation

georgewrmarshall
Copy link
Collaborator

Description

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot
Copy link
Collaborator

Builds ready [fec2301]

Storybook: Storybook

@metamaskbot
Copy link
Collaborator

Builds ready [02d4a65]

Storybook: Storybook

@@ -1,4 +1,4 @@
import { Canvas } from '@storybook/addon-docs/blocks';
import { Canvas } from '@storybook/blocks';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating deprecated storybook import

Screenshot 2024-04-24 at 3 54 17 PM

@metamaskbot
Copy link
Collaborator

Builds ready [0f725ae]

Storybook: Storybook

@georgewrmarshall georgewrmarshall deleted the fix/656/json branch April 25, 2024 21:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants